Add support for metadata.code.branch_hint section #4460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasdoe
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
|
(rebased on main) |
yamt
reviewed
Jul 8, 2025
lum1n0us
reviewed
Jul 9, 2025
|
Alright, the changes from the review are now committed. Thank you very much for taking the time and effort to give such a good review :) Concerning your question about branch hints and the interpreter: |
lum1n0us
added
the
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're currently in the progress of upstreaming the generation of the code metadata branch hint section in llvm (PR), I also implemented support for this feature in wamr.
One important consideration for the implementation was to keep the encoding of hints generic, so that more compilation hints could be added in the future.